Skip to content

Add Timer::pause #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Add Timer::pause #239

merged 1 commit into from
Aug 7, 2025

Conversation

yshui
Copy link
Contributor

@yshui yshui commented Aug 5, 2025

Closes #238

notgull
notgull requested changes Aug 5, 2025
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to just make "clear" public.

@yshui
Make Timer::clear public
01f3055 
Closes smol-rs#238

Signed-off-by: Yuxuan Shui <[email protected]>
@yshui
Copy link
Contributor Author

yshui commented Aug 6, 2025

@notgull updated. i don't know if setting self.when = None; is necessary, but i did that to be consistent with the other cases of turing-timer-offs.

notgull
notgull approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit d1c6738 into smol-rs:master Aug 7, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stop timer
2 participants
@yshui @notgull